Document #[diagnostic::on_move] in the unstable book. by mejrs · Pull Request #155621 · rust-lang/rust

mejrs · 2026-04-21T21:47:15Z

Also adds the attribute on std::fs::File to stay consistent with the prose in the unstable book entry.

Rendered:

rustbot · 2026-04-21T21:47:20Z

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 17 candidates

rperier · 2026-04-22T06:38:25Z

I would put the same kind of details in the diagnostic attribute of std::fs::File than on Rc and Arc (see 92ed4a2) : the idea being explain briefly why the user can use try_clone or clone , because it's cheap or designed for that purpose (or another reason). And then, you can then refer to File::try_clone from the notes. Because currently the compiler already talks about .clone() when the type implements the Clone trait, so just a supplementary note refering to File::try_clone is a bit confusing, imho. Providing more context to the user would be helpful.

+1 for the documentation, good idea ;)

mejrs · 2026-04-22T21:59:48Z

File doesn't implement Clone, though, and we do not reference the File diagnostic item anywhere so there are no specialized diagnostics for it.

chenyukang · 2026-04-23T10:54:28Z

+}
+```
+The user may try to use it like this:
+```rust


maybe need to mark compile_fail

```rust,compile_fail,E0382

View changes since the review

oh, right. I'd forgotten this and to mark the error message as "text"...

chenyukang · 2026-04-23T10:54:58Z

r=me after CI is green.

mejrs · 2026-04-23T14:40:44Z

@bors r=chenyukang

rust-bors · 2026-04-23T14:40:49Z

📌 Commit ce880a4 has been approved by chenyukang

It is now in the queue for this repository.

@estebank

… r=chenyukang Document #[diagnostic::on_move] in the unstable book. Also adds the attribute on `std::fs::File` to stay consistent with the prose in the unstable book entry. cc @estebank @rperier Rendered: <img width="791" height="903" alt="image" src="https://github.com/user-attachments/assets/a27a5211-7717-4f7f-a514-8316dccc78d5" /> <img width="779" height="390" alt="image" src="https://github.com/user-attachments/assets/a983108d-575e-4551-ab14-28611344e9b0" />

…uwer Rollup of 7 pull requests Successful merges: - #155621 (Document #[diagnostic::on_move] in the unstable book.) - #155671 (Simplify `Config::track_state`.) - #153482 (tests/ui/macros: add annotations for reference rules) - #155075 (Add docs about SDKs and C compilation on armv7a-vex-v5) - #155685 (Fix `get_child_at_index` return type hints) - #155686 (Fix array template arg lookup behavior) - #155690 (Fix classify_union to return Union for regular unions)

@estebank

Document #[diagnostic::on_move] in the unstable book. Also adds the attribute on `std::fs::File` to stay consistent with the prose in the unstable book entry. cc @estebank @rperier Rendered: <img width="791" height="903" alt="image" src="https://github.com/user-attachments/assets/a27a5211-7717-4f7f-a514-8316dccc78d5" /> <img width="779" height="390" alt="image" src="https://github.com/user-attachments/assets/a983108d-575e-4551-ab14-28611344e9b0" />

rust-bors · 2026-04-23T23:05:01Z

💔 Test for 018e1e6 failed: CI. Failed job:

auto - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-04-24T08:40:24Z

@bors retry
Spurious

@estebank

… r=chenyukang Document #[diagnostic::on_move] in the unstable book. Also adds the attribute on `std::fs::File` to stay consistent with the prose in the unstable book entry. cc @estebank @rperier Rendered: <img width="791" height="903" alt="image" src="https://github.com/user-attachments/assets/a27a5211-7717-4f7f-a514-8316dccc78d5" /> <img width="779" height="390" alt="image" src="https://github.com/user-attachments/assets/a983108d-575e-4551-ab14-28611344e9b0" />

@estebank

… r=chenyukang Document #[diagnostic::on_move] in the unstable book. Also adds the attribute on `std::fs::File` to stay consistent with the prose in the unstable book entry. cc @estebank @rperier Rendered: <img width="791" height="903" alt="image" src="https://github.com/user-attachments/assets/a27a5211-7717-4f7f-a514-8316dccc78d5" /> <img width="779" height="390" alt="image" src="https://github.com/user-attachments/assets/a983108d-575e-4551-ab14-28611344e9b0" />

…uwer Rollup of 12 pull requests Successful merges: - #149452 (Refactor out common code into a `IndexItem::new` constructor) - #155621 (Document #[diagnostic::on_move] in the unstable book.) - #155635 (delegation: rename `Self` generic param to `This` in recursive delegations) - #155730 (Some cleanups around per parent disambiguators) - #153537 (rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu) - #155219 (Do not suggest borrowing enclosing calls for nested where-clause obligations) - #155408 (rustdoc: Fix Managarm C Library name in cfg pretty printer) - #155571 (Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf) - #155713 (test: Add a regression test for Apple platforms aborting on `free`) - #155723 (Fix tier level for 5 thumb bare-metal ARM targets) - #155735 (Fix typo by removing extra 'to') - #155736 (Remove `AllVariants` workaround for rust-analyzer)

@estebank

Rollup merge of #155621 - mejrs:document_diagnostic_on_move, r=chenyukang Document #[diagnostic::on_move] in the unstable book. Also adds the attribute on `std::fs::File` to stay consistent with the prose in the unstable book entry. cc @estebank @rperier Rendered: <img width="791" height="903" alt="image" src="https://github.com/user-attachments/assets/a27a5211-7717-4f7f-a514-8316dccc78d5" /> <img width="779" height="390" alt="image" src="https://github.com/user-attachments/assets/a983108d-575e-4551-ab14-28611344e9b0" />

Put #[diagnostic::on_move] on File

70cf3f4

rustbot assigned chenyukang Apr 21, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 21, 2026

This comment has been minimized.

Sign in to view

mejrs force-pushed the document_diagnostic_on_move branch from 3504f9a to f010a15 Compare April 22, 2026 23:36

This comment has been minimized.

Sign in to view

rperier mentioned this pull request Apr 23, 2026

Tracking Issue for #[diagnostic::on_move] #154181

Open

7 tasks

mejrs force-pushed the document_diagnostic_on_move branch from f010a15 to 9bf0c26 Compare April 23, 2026 10:19

chenyukang reviewed Apr 23, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Document #[diagnostic::on_move] in the unstable book

ce880a4

mejrs force-pushed the document_diagnostic_on_move branch from 9bf0c26 to ce880a4 Compare April 23, 2026 11:40

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2026

JonathanBrouwer mentioned this pull request Apr 23, 2026

Rollup of 7 pull requests #155700

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 23, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026

JonathanBrouwer mentioned this pull request Apr 24, 2026

Rollup of 6 pull requests #155742

Closed

This was referenced Apr 24, 2026

Rollup of 8 pull requests #155743

Closed

Rollup of 12 pull requests #155745

Merged

rust-bors Bot merged commit e873839 into rust-lang:main Apr 24, 2026
11 of 12 checks passed

rustbot added this to the 1.97.0 milestone Apr 24, 2026

Uh oh!

Conversation

mejrs commented Apr 21, 2026

Uh oh!

rustbot commented Apr 21, 2026

Uh oh!

This comment has been minimized.

rperier commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mejrs commented Apr 22, 2026

Uh oh!

This comment has been minimized.

chenyukang Apr 23, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mejrs Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

chenyukang commented Apr 23, 2026

Uh oh!

This comment has been minimized.

mejrs commented Apr 23, 2026

Uh oh!

rust-bors Bot commented Apr 23, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Apr 23, 2026

Uh oh!

JonathanBrouwer commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rperier commented Apr 22, 2026 •

edited

Loading

chenyukang Apr 23, 2026 •

edited by rustbot

Loading